Fix crashes when config file is missing general/keymap sections#13
Open
Enrico68 wants to merge 1 commit into
Open
Fix crashes when config file is missing general/keymap sections#13Enrico68 wants to merge 1 commit into
Enrico68 wants to merge 1 commit into
Conversation
- Fallback to English Wikipedia when no default wiki is configured - Fallback to empty keymap when no keymap section exists - Use local manpage for :help and show error on command failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several crashes that occur when wikicurses is run without an existing configuration file.
Changes:
KeyError: 'general': Useconf.get()with a fallback to the English Wikipedia API URL when no default wiki is configured.KeyError: 'keymap': Check if thekeymapsection exists before accessing it, defaulting to an empty mapping.These changes allow first-time users to run wikicurses immediately after installation without having to create a config file first.